Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Performance index always returns 100% #220

Open
ryanjclark opened this issue Sep 4, 2023 · 1 comment
Open

Performance index always returns 100% #220

ryanjclark opened this issue Sep 4, 2023 · 1 comment

Comments

@ryanjclark
Copy link

I don't think this query makes sense. It always returns 100%, even on a stricter bucket like le="5".

I think a more appropriate query would be:

    sum(
      rate(
        strimzi_canary_records_consumed_latency_bucket{le="5"}[5m]
      )
    )
  /
    sum(
      rate(
        strimzi_canary_records_consumed_latency_bucket{le="+Inf"}[5m]
      )
    )
*
  100
@pantaoran
Copy link

I was also thinking about this recently.
We had a situation where the average latency of one broker was consistently >1000ms. This led to the performance index just omitting that broker's time series, because it resulted in NaN since the dividend was 0.
The line of the performance index was still a straight 100%, just with the values from the "bad" broker missing. That is pretty useless I feel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants