Add formatted content description for Expiration Date text field #10185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stripe-ui-core/src/main/java/com/stripe/android/uicore/elements/TextFieldUI.kt
Outdated
Show resolved
Hide resolved
stripe-ui-core/src/main/java/com/stripe/android/uicore/elements/TextFieldUI.kt
Outdated
Show resolved
Hide resolved
stripe-ui-core/src/main/java/com/stripe/android/uicore/elements/TextFieldUI.kt
Outdated
Show resolved
Hide resolved
| return resolvableString(R.string.stripe_expiration_date_empty_content_description) | ||
| } | ||
|
|
||
| val canOnlyBeSingleDigitMonth = input.isNotBlank() && !(input[0] == '0' || input[0] == '1') |
There was a problem hiding this comment.
This split logic taken from ExpiryDateVisualTransformation
|
Diffuse output: APKDEXARSC |
amk-stripe
reviewed
Feb 18, 2025
...-ui-core/src/test/java/com/stripe/android/utils/ExpiryDateContentDescriptionFormatterTest.kt
Show resolved
Hide resolved
|
|
||
| return input.resolvableString | ||
| } catch (e: Exception) { | ||
| return input.resolvableString |
There was a problem hiding this comment.
which exceptions are we catching here and why is it ok to ignore them?
Can you consider:
- catching specific exceptions here
- adding a comment about why it is ok that we are ignoring the exceptions
There was a problem hiding this comment.
Updated to ParseException and left a comment on why it's fine to ignore. ParseException should never be thrown but since the text passed in here is coming directly from the TextField input we don't want to crash the app if somehow a non numeric string is entered
amk-stripe
previously approved these changes
Feb 18, 2025
…t description as the label has been removed from semantics
amk-stripe
previously approved these changes
Feb 18, 2025
amk-stripe
previously approved these changes
Feb 18, 2025
samer-stripe
previously approved these changes
Feb 19, 2025
amk-stripe
approved these changes
Feb 21, 2025
samer-stripe
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds custom content description for expiry date text field
Adds
formatExpirationDateForAccessibilitywhich takes raw input from Expiry Date text field and returns a resolvable string formatted with month and yearFor the following inputs, a screen reader will announce:
""->Expiration date. Two digit month and two digit year, empty"4 /"->Expiration date. April and two digit year, empty"4 / 2"->Expiration date. April and two digit year, incomplete"4 / 25"->Expiration date. April 2025Motivation
Improve accessibility
Testing
Screen.Recording.2025-02-14.at.4.57.05.PM.mov