-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOBILESDK-2686] Add setAsDefault to ConfirmPaymentIntentParams and ConfirmSetupIntentParams #10206
Conversation
Diffuse output:
APK
DEX
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this PR, can we include how this new parameter is being set? As this currently is, it looks like we're checking in this new parameter unused, which also means we can't add testing to this PR. I'd prefer it to be a bit larger so that we can validate that it actually works and so I can see how it hooks up to everything else
/** | ||
* Indicates that this should be the default payment method going forward | ||
*/ | ||
var setAsDefaultPaymentMethod: Boolean? = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this an internal val? I don't think this needs to be public API
/** | ||
* Indicates that this should be the default payment method going forward | ||
*/ | ||
var setAsDefaultPaymentMethod: Boolean? = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as for payment intents -- can this be internal?
closing PR b/c too small |
Summary
Added setAsDefaultPaymentMethod as field to ConfirmPaymentIntentParams and ConfirmSetupIntentParams
Motivation
https://jira.corp.stripe.com/browse/MOBILESDK-2684
https://jira.corp.stripe.com/browse/MOBILESDK-2686
Testing
N.A.
Screenshots
N.A.
Changelog
N.A.