Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a flakey test in VerticalModePaymentSheetActivityTest. #10224

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

There shouldn't really be a difference between these 2, but it does fix the flakes.

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review February 19, 2025 23:48
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners February 19, 2025 23:48
Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +4 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +4 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20099 │ 20099 │ 0 (+0 -0) 
   types │  6215 │  6215 │ 0 (+0 -0) 
 classes │  5010 │  5010 │ 0 (+0 -0) 
 methods │ 29958 │ 29958 │ 0 (+0 -0) 
  fields │ 17314 │ 17314 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
  1.2 KiB │ +4 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 25.7 KiB │ +1 B │ 63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 27.1 KiB │ +4 B │ 65.2 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe merged commit 968a99d into master Feb 20, 2025
13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/flake-fix-again branch February 20, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants