Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flakes in PaymentOptionsViewModelTest. #10228

Merged

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

This one doesn't fix the flake, but improves it by about 20x from my testing. Fails about every 6k times rather than every 300 times before.

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/PaymentOptionsViewModelTest-flake-fix branch from 0166ec1 to 2bddf94 Compare February 20, 2025 00:55
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review February 20, 2025 00:55
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners February 20, 2025 00:55
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) February 20, 2025 00:55
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │    95 KiB │  95.1 KiB │ +9 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +9 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20099 │ 20099 │ 0 (+0 -0) 
   types │  6215 │  6215 │ 0 (+0 -0) 
 classes │  5010 │  5010 │ 0 (+0 -0) 
 methods │ 29958 │ 29958 │ 0 (+0 -0) 
  fields │ 17314 │ 17314 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.9 KiB │ +4 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │ +2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 25.7 KiB │ +2 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
   56 KiB │ +9 B │ 129.2 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe merged commit 78b3179 into master Feb 20, 2025
13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/PaymentOptionsViewModelTest-flake-fix branch February 20, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants