Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change update screen padding. #10232

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Feb 20, 2025

Summary

During embedded design review, JJ suggested we move this up by 2dp.

Motivation

https://docs.google.com/document/d/1IdcaDPOAiMFpAq7zlL9aw5w5U-P9pK5YXqRu6GM56X4/edit?tab=t.0

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ +3 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +3 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20102 │ 20102 │ 0 (+0 -0) 
   types │  6216 │  6216 │ 0 (+0 -0) 
 classes │  5011 │  5011 │ 0 (+0 -0) 
 methods │ 29963 │ 29963 │ 0 (+0 -0) 
  fields │ 17341 │ 17341 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 25.7 KiB │ +2 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
 28.9 KiB │ +1 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
──────────┼──────┼───────────┼──────┼────────────────────────
 54.6 KiB │ +3 B │ 127.9 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/update-padding branch from 517ba06 to 2727a2c Compare February 20, 2025 16:33
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review February 20, 2025 16:41
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners February 20, 2025 16:41
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) February 20, 2025 16:41
@jaynewstrom-stripe jaynewstrom-stripe merged commit 6cf131e into master Feb 20, 2025
13 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/update-padding branch February 20, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants