Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch FC playground merchants from backend #10244

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Feb 20, 2025

Summary

This pull request updates the Financial Connections playground to fetch test merchants from the backend, instead of hard-coding them. This allows us to easily add new test merchants that are gated into specific features we’re working on.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ -5 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -5 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20102 │ 20102 │ 0 (+0 -0) 
   types │  6216 │  6216 │ 0 (+0 -0) 
 classes │  5011 │  5011 │ 0 (+0 -0) 
 methods │ 29963 │ 29963 │ 0 (+0 -0) 
  fields │ 17341 │ 17341 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
   compressed    │   uncompressed   │                        
──────────┬──────┼───────────┬──────┤                        
 size     │ diff │ size      │ diff │ path                   
──────────┼──────┼───────────┼──────┼────────────────────────
 28.9 KiB │ -5 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
 25.7 KiB │ -1 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼──────┼───────────┼──────┼────────────────────────
 55.7 KiB │ -5 B │ 129.1 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe force-pushed the tillh/fc-playground-merchants branch 3 times, most recently from d434f74 to 129beba Compare February 20, 2025 21:15
@tillh-stripe tillh-stripe marked this pull request as ready for review February 20, 2025 21:18
@tillh-stripe tillh-stripe requested review from a team as code owners February 20, 2025 21:18
@tillh-stripe tillh-stripe enabled auto-merge (squash) February 20, 2025 21:18
@tillh-stripe tillh-stripe force-pushed the tillh/fc-playground-merchants branch from 129beba to cac07c5 Compare February 20, 2025 21:31
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@tillh-stripe tillh-stripe merged commit 60fa2e6 into master Feb 20, 2025
13 checks passed
@tillh-stripe tillh-stripe deleted the tillh/fc-playground-merchants branch February 20, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants