Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move navigation back on card brand success logic into update PM interactor #10246

Merged

Conversation

amk-stripe
Copy link
Collaborator

Summary

Move navigation back on card brand success logic into update PM interactor

Motivation

When we add the ability to set a PM as your default on this screen, it will be possible for users to update both their card brand and their default payment method with the same click of the "save" button. In this case, we will NOT want to navigate back if updating the card brand succeeds but setting the default fails (we want to show an error message when setting the default fails).

This enables that by having the interactor be responsible for navigating back, rather than each implementation of the card brand updating logic.

Testing

  • Added tests
  • Modified tests
  • Manually verified

No behavior change in this PR.

Copy link
Contributor

github-actions bot commented Feb 20, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.3 KiB │   7.3 KiB │  0 B │   7.1 KiB │   7.1 KiB │  0 B 
    other │  95.1 KiB │  95.1 KiB │ -8 B │ 182.2 KiB │ 182.2 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -8 B │  21.6 MiB │  21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20102 │ 20102 │ 0 (+0 -0) 
   types │  6216 │  6216 │ 0 (+0 -0) 
 classes │  5011 │  5011 │ 0 (+0 -0) 
 methods │ 29963 │ 29963 │ 0 (+0 -0) 
  fields │ 17341 │ 17341 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
   compressed    │ uncompressed  │                    
──────────┬──────┼────────┬──────┤                    
 size     │ diff │ size   │ diff │ path               
──────────┼──────┼────────┼──────┼────────────────────
 28.9 KiB │ -8 B │ 64 KiB │  0 B │ ∆ META-INF/CERT.SF 
──────────┼──────┼────────┼──────┼────────────────────
 28.9 KiB │ -8 B │ 64 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review February 20, 2025 21:42
@amk-stripe amk-stripe requested review from a team as code owners February 20, 2025 21:42
@amk-stripe amk-stripe merged commit 1879167 into master Feb 20, 2025
13 checks passed
@amk-stripe amk-stripe deleted the move-update-success-logic-into-update-pm-interactor branch February 20, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants