Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crypto icon light/dark theme #10267

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

ericzhang-stripe
Copy link
Contributor

@ericzhang-stripe ericzhang-stripe commented Feb 25, 2025

Summary

fix crypto icon light/dark theme (the icons were switched)

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screenshot_20250225_163017

Changelog

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │        uncompressed        
          ├───────────┬───────────┬──────┼──────────┬──────────┬──────
 APK      │ old       │ new       │ diff │ old      │ new      │ diff 
──────────┼───────────┼───────────┼──────┼──────────┼──────────┼──────
      dex │   4.1 MiB │   4.1 MiB │  0 B │    9 MiB │    9 MiB │  0 B 
     arsc │   2.4 MiB │   2.4 MiB │  0 B │  2.4 MiB │  2.4 MiB │  0 B 
 manifest │   5.1 KiB │   5.1 KiB │  0 B │ 25.7 KiB │ 25.7 KiB │  0 B 
      res │ 910.9 KiB │ 910.9 KiB │  0 B │  1.4 MiB │  1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │    6 MiB │    6 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  0 B │  1.6 MiB │  1.6 MiB │  0 B 
    other │   1.4 MiB │   1.4 MiB │ +2 B │  1.6 MiB │  1.6 MiB │  0 B 
──────────┼───────────┼───────────┼──────┼──────────┼──────────┼──────
    total │  12.9 MiB │  12.9 MiB │ +2 B │ 22.1 MiB │ 22.1 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42782 │ 42782 │ 0 (+0 -0) 
   types │ 15351 │ 15351 │ 0 (+0 -0) 
 classes │ 12958 │ 12958 │ 0 (+0 -0) 
 methods │ 62691 │ 62691 │ 0 (+0 -0) 
  fields │ 41698 │ 41698 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6273 │ 6273 │  0
APK
    compressed    │   uncompressed   │                                           
───────────┬──────┼───────────┬──────┤                                           
 size      │ diff │ size      │ diff │ path                                      
───────────┼──────┼───────────┼──────┼───────────────────────────────────────────
     963 B │ -5 B │   1.6 KiB │  0 B │ ∆ res/NR.xml                              
     968 B │ +5 B │   1.6 KiB │  0 B │ ∆ res/XF.xml                              
    54 KiB │ +2 B │   120 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  50.6 KiB │ +2 B │ 119.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
     271 B │ -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
   1.2 KiB │ -1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
───────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 107.9 KiB │ +2 B │ 244.5 KiB │  0 B │ (total)

Copy link
Collaborator

@amk-stripe amk-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this manually tested? Can you attach screenshots to the PR?

@ericzhang-stripe ericzhang-stripe merged commit e2e328a into master Feb 26, 2025
16 checks passed
@ericzhang-stripe ericzhang-stripe deleted the ericzhang-crypto-icon-theme branch February 26, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants