Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorsLight and colorsDark to Embedded Row Style #10269

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tjclawson-stripe
Copy link
Collaborator

@tjclawson-stripe tjclawson-stripe commented Feb 26, 2025

Summary

Add colorsLight and colorsDark to FlatWithRadio and FlatWithCheckmark Embedded Row Styles

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3159

Testing

  • Added tests
  • Modified tests
  • Manually verified

FlatWithRadio Screenshots

Before After
radio_dark_before radio_dark_after

FlatWithCheckmark Screenshots

Before After
checkmark_dark_before checkmark_dark_after

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │     2 MiB │     2 MiB │ +147 B │   4.1 MiB │   4.1 MiB │ +24 B 
     arsc │     1 MiB │     1 MiB │    0 B │     1 MiB │     1 MiB │   0 B 
 manifest │   2.3 KiB │   2.3 KiB │    0 B │     8 KiB │     8 KiB │   0 B 
      res │ 302.6 KiB │ 302.6 KiB │    0 B │ 456.7 KiB │ 456.7 KiB │   0 B 
   native │   6.2 MiB │   6.2 MiB │    0 B │  15.8 MiB │  15.8 MiB │   0 B 
    asset │   7.3 KiB │   7.3 KiB │   +2 B │   7.1 KiB │   7.1 KiB │  +2 B 
    other │  95.1 KiB │  95.1 KiB │   +4 B │ 182.2 KiB │ 182.2 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │   9.6 MiB │   9.6 MiB │ +153 B │  21.6 MiB │  21.6 MiB │ +26 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20114 │ 20114 │ 0 (+1 -1) 
   types │  6221 │  6221 │ 0 (+0 -0) 
 classes │  5015 │  5015 │ 0 (+0 -0) 
 methods │ 29998 │ 29998 │ 0 (+0 -0) 
  fields │ 17347 │ 17347 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3643 │ 3643 │  0
APK
    compressed     │   uncompressed   │                               
──────────┬────────┼──────────┬───────┤                               
 size     │ diff   │ size     │ diff  │ path                          
──────────┼────────┼──────────┼───────┼───────────────────────────────
    2 MiB │ +147 B │  4.1 MiB │ +24 B │ ∆ classes.dex                 
 25.7 KiB │   +7 B │ 63.9 KiB │   0 B │ ∆ META-INF/MANIFEST.MF        
  6.5 KiB │   +2 B │  6.4 KiB │  +2 B │ ∆ assets/dexopt/baseline.prof 
 28.9 KiB │   -2 B │   64 KiB │   0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │   -1 B │  1.2 KiB │   0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼──────────┼───────┼───────────────────────────────
    2 MiB │ +153 B │  4.2 MiB │ +26 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   20114 │ 20114 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"c77bc20","r8-mode":"full","version":"8.8.27"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"80ad8e7","r8-mode":"full","version":"8.8.27"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant