Skip to content
This repository has been archived by the owner on Jan 27, 2019. It is now read-only.

[Question] Maybe add an item if this tool works with react only? #38

Open
btd opened this issue Nov 28, 2016 · 3 comments
Open

[Question] Maybe add an item if this tool works with react only? #38

btd opened this issue Nov 28, 2016 · 3 comments

Comments

@btd
Copy link

btd commented Nov 28, 2016

Hi, there, even if this comparison to me looks very opinion based.
I think it could be very nice to add item for more robust if this tool works not only with react (e.g css modules generates classes - so it is framework agnostic).
Also it could be nice to add size of runtime included in bundle.

@mxstbr
Copy link
Member

mxstbr commented Nov 28, 2016

It is totally based on my own opinions, no doubt about that! It's not as biased as it might look, as I made the comparison before styled-components was a thing.

Those two would certainly be useful additions!

@btd
Copy link
Author

btd commented Nov 28, 2016

@mxstbr thanks! I actually like how this examples is done. Sorry if it was look a bit rude, did not mean to be.

@stereobooster
Copy link

stereobooster commented Nov 29, 2017

Ultimate list of feature requests compiled from MicheleBertoli/css-in-js issues

  • @Keyframes support
  • @font-face support
  • @media queries support (in CSS and not via JS simulation)
  • pseudo classes support (in CSS and not via JS simulation)
  • framework agnostic (not just React)
  • SSR
  • ReactNative support
  • Are CSS rule declaration bodies safe by default? React Inline runs everything through escapeTextContentForBrowser to avoid XSS.
  • Are at-media selectors safe by default (@import is open to CSRF)?
  • Is there a build step?
  • Works with CRA without ejecting
  • rendering technics:
    • generates CSS and inserts style element
    • uses inline styles
    • mixed mode: inline styles, CSS, reacts event system for :hover and co (radium)
  • Syntax
    • Object literals
    • Template literals
  • GitHub stars
  • last update
  • size of runtime dependency

See also https://github.com/stereobooster/css-in-js-systematic-approach

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants