Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] union keyword not recognized #3159

Closed
cbiffle opened this issue Dec 8, 2021 · 8 comments
Closed

[Rust] union keyword not recognized #3159

cbiffle opened this issue Dec 8, 2021 · 8 comments
Labels
T: bug A bug in an existing language feature

Comments

@cbiffle
Copy link

cbiffle commented Dec 8, 2021

What happened?

Hi! I'm using your syntax definitions rather indirectly, via the Rust syntect crate compiled into the Zola static site generator.

I note that in the first source listing in this section of my blog, the union keyword is not recognized/attributed. It appears in the Rust definition in this repo, the word union does not appear, so I believe it's an issue with the syntax definition.

@cbiffle cbiffle added the T: bug A bug in an existing language feature label Dec 8, 2021
@michaelblyons
Copy link
Collaborator

Try PR #2305

@cbiffle
Copy link
Author

cbiffle commented Dec 9, 2021

Diff looks plausible -- unfortunately (1) I'm stuck on a version of Zola that can't load syntax files at runtime because the newer versions were released with catastrophic bugs and (2) it's not straightforward to build against that PR to update the compiled-in syntax file because it's in a submodule of a dependency of a dependency. :-\

@michaelblyons
Copy link
Collaborator

If you're stuck on an old version, how does updating this repo help you?

@Alexey-T
Copy link

Alexey-T commented Dec 9, 2021

@cbiffle Thanks for your note (just improved my own tool which had the same issue, offtopic)

@cbiffle
Copy link
Author

cbiffle commented Dec 9, 2021

If you're stuck on an old version, how does updating this repo help you?

Well, I figured it improves this repo's syntax definitions and once Zola fixes some bugs I might also benefit? If you'd rather I didn't report the bugs, I can close this, I'm a little confused.

@michaelblyons
Copy link
Collaborator

Please feel free to report bugs here. I am just unsure how improvements will help you, given your constraints.

If you are later able to use newer versions of Zola and they do allow you to wire in alternative syntax definitions, you are welcome to try out PRs and unreleased versions.

@cbiffle
Copy link
Author

cbiffle commented Dec 10, 2021

That PR looks to have been open for quite a while, is it in need of verification? If that's what it's blocked on I could try to cobble together a custom build of the world. But the final comment on the PR suggests that it's hung up on other procedural things.

@deathaxe
Copy link
Collaborator

deathaxe commented Jan 8, 2022

Fixed by #2305

@deathaxe deathaxe closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug A bug in an existing language feature
Projects
None yet
Development

No branches or pull requests

4 participants