Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow identifiers in SDK calls in place of environment and userId #42

Open
flaki opened this issue Dec 7, 2022 · 1 comment
Open

Allow identifiers in SDK calls in place of environment and userId #42

flaki opened this issue Dec 7, 2022 · 1 comment

Comments

@flaki
Copy link
Contributor

flaki commented Dec 7, 2022

We use identifier in a couple places when we talk about our API (and even in the API, such as here for the builder).

Practically the identifier is produced from the strings identifying the environment and tenant, and the API has been using these two separately and making the identifier inside the call. Would it make sense to accept either an identifier or an environment and userId in the SDK functions?

In my local version I have "deprecated" the environment+userId combination, but I don't see why we couldn't provide the flexibility to provide either here.

@rnpridgeon
Copy link

My .02 is should we move away from specifying the environment in the identifier all together. Clients already work under the context of a single environment which could be derived from the environment token they use to authenticate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants