Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--elf-name is ignored when --output-directory is missing #1979

Open
2 tasks done
srdtrk opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1982
Open
2 tasks done

--elf-name is ignored when --output-directory is missing #1979

srdtrk opened this issue Jan 24, 2025 · 0 comments · May be fixed by #1982

Comments

@srdtrk
Copy link
Contributor

srdtrk commented Jan 24, 2025

Component

cargo prove CLI/sp1up

Have you ensured that all of these are up to date?

  • SP1 SDK
  • cargo prove CLI/sp1up

What version of SP1 SDK are you on?

No response

What version of the cargo prove CLI are you on?

4a1dcea 2025-01-15T23:21:07.590940000Z

Operating System

None

Describe the bug

cargo prove build accepts --elf-name and --output-directory arguments. If --elf-name is present while the --output-directory is not, then the --elf-name is fully ignored and the binary is generated in the target/ directory with the default name. The user also receives this warning.

The warning doesn't make it clear that --elf-name is ignored. Moreover, in a different but similar scenario, cargo-prove simply returns an error when --elf-name would be ignored. I believe that in this scenario, cargo-prove should simply return an error, or use the --elf-name.

@srdtrk srdtrk changed the title --elf-name is ignored when --output-directory is not used --elf-name is ignored when --output-directory is missing Jan 24, 2025
@nhtyy nhtyy linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant