From e18c4dea5df0feb7df9b9f08438ba4464c2d517e Mon Sep 17 00:00:00 2001 From: "keroroxx520@gmail.com" Date: Wed, 25 Dec 2024 00:42:13 +0800 Subject: [PATCH] fix: return error instead of panic when fail to upload artifact --- crates/sdk/src/network/client.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/sdk/src/network/client.rs b/crates/sdk/src/network/client.rs index 880352c5c..1b4e94a45 100644 --- a/crates/sdk/src/network/client.rs +++ b/crates/sdk/src/network/client.rs @@ -261,9 +261,9 @@ impl NetworkClient { self.http.put(&presigned_url).body(bincode::serialize::(item)?).send().await?; if !response.status().is_success() { - log::debug!("Artifact upload failed with status: {}", response.status()); + log::error!("Artifact upload failed with status: {}", response.status()); + return Err(anyhow::anyhow!("failed to upload artifact: HTTP {}", response.status())); } - assert!(response.status().is_success()); Ok(uri) }