Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some shortcut keys not working #4441

Open
4 tasks
Aman1919 opened this issue Feb 21, 2025 · 10 comments
Open
4 tasks

Some shortcut keys not working #4441

Aman1919 opened this issue Feb 21, 2025 · 10 comments

Comments

@Aman1919
Copy link
Contributor

Description

Some shortcut keys are not functioning as expected:

  1. Alt + H: I believe this was intended for saving the file, but it’s behaving strangely. It continuously downloads multiple SVG files, makes the website blink, and essentially breaks the site.
  2. Space: This seems to be meant for collapsing or expanding the screen, but it’s not working as intended.
  3. Alt + D: I’m not sure what this shortcut is supposed to do, but it’s throwing errors in the console.
  4. Delete: I assume this is meant for extracting a block, but it doesn’t appear to do anything.

Expected Behavior

Screenshots

Alt + H

Screencast.from.2025-02-21.13-39-25.webm

space

Screencast.from.2025-02-21.14-00-36.webm

Alt + D

Image

How to Reproduce

Console log Errors:

Environment:

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@Aman1919
Copy link
Contributor Author

@walterbender What are your thoughts?

@walterbender
Copy link
Member

Alt-H is behaving properly. It is used to generate artwork for every block. It needs to be documented as such. Not sure why the clear screen dialog appears.

space should be used for a rest note, not canvas sizing.

Alt-D I am not sure about. Nothing wrong with using it to extract a block, but maybe Alt-X would be easier to remember?

@vara-prasad-07
Copy link

Hii @Aman1919 ,is this issue open to work by me ?

@walterbender
Copy link
Member

@vara-prasad-07 we don't assign issues

@Aman1919
Copy link
Contributor Author

Aman1919 commented Feb 24, 2025

Hii @Aman1919 ,is this issue open to work by me ?

Sure you can work on this

@vara-prasad-07
Copy link

Hi @walterbender, @Aman1919,

Could someone please explain the expected behavior when using "Alt+D"?

Current Behavior:
When "Alt+D" is pressed in the console, an error message appears, as shown in the image below:

Image

Issue:
We are calling "this.palettes.dict.myblocks.promptMacrosDelete()", but "promptMacrosDelete()" function is undefined.

Image

In above pic we can observe that "promptMarcosDelete()" is called in activity.js but not implemented in any other js files

I need to understand what the expected behavior for the "Alt+D" key combination is so that I can properly define the "promptMacrosDelete()" function.

Thank you!

@walterbender
Copy link
Member

I don't think we need a keyboard shortcut for anything plugin related.
Also, anything associated with the Planet will fail as the Planet is currently down.

@vara-prasad-07
Copy link

Hi @walterbender,

I understand your point. Since Planet is currently down, we don't need a specific keyboard shortcut for "Alt+D." Instead, we should implement the "promptMacrosDelete()" instance method and pass the function. This way, the console will have no errors when the user uses the "Alt+D" keyword. Later, if we need to implement a keyword shortcut, we can rewrite the "promptMacrosDelete()" function.

Thank you!

@walterbender
Copy link
Member

I am not sure what promptMacrosDelete is intended to do, but it certainly does not need a shortcut key. It should be removed.

@vara-prasad-07
Copy link

vara-prasad-07 commented Mar 2, 2025

yes, @walterbender , I will remove the undefined promptMacrosDelete method and i was working on the remaining shortcut keys issues. I will make pr as soon as possible

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants