-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some shortcut keys not working #4441
Comments
@walterbender What are your thoughts? |
Alt-H is behaving properly. It is used to generate artwork for every block. It needs to be documented as such. Not sure why the clear screen dialog appears. space should be used for a rest note, not canvas sizing. Alt-D I am not sure about. Nothing wrong with using it to extract a block, but maybe Alt-X would be easier to remember? |
Hii @Aman1919 ,is this issue open to work by me ? |
@vara-prasad-07 we don't assign issues |
Sure you can work on this |
Hi @walterbender, @Aman1919, Could someone please explain the expected behavior when using "Alt+D"? Current Behavior: Issue: In above pic we can observe that "promptMarcosDelete()" is called in activity.js but not implemented in any other js files I need to understand what the expected behavior for the "Alt+D" key combination is so that I can properly define the "promptMacrosDelete()" function. Thank you! |
I don't think we need a keyboard shortcut for anything plugin related. |
Hi @walterbender, I understand your point. Since Planet is currently down, we don't need a specific keyboard shortcut for "Alt+D." Instead, we should implement the "promptMacrosDelete()" instance method and pass the function. This way, the console will have no errors when the user uses the "Alt+D" keyword. Later, if we need to implement a keyword shortcut, we can rewrite the "promptMacrosDelete()" function. Thank you! |
I am not sure what promptMacrosDelete is intended to do, but it certainly does not need a shortcut key. It should be removed. |
yes, @walterbender , I will remove the undefined promptMacrosDelete method and i was working on the remaining shortcut keys issues. I will make pr as soon as possible Thank you! |
Description
Some shortcut keys are not functioning as expected:
Expected Behavior
Screenshots
Alt + H
Screencast.from.2025-02-21.13-39-25.webm
space
Screencast.from.2025-02-21.14-00-36.webm
Alt + D
How to Reproduce
Console log Errors:
Environment:
Checklist
Thank you for contributing to our project! We appreciate your help in improving it.
📚 See contributing instructions.
🙋🏾🙋🏼 Questions: Community Matrix Server.
The text was updated successfully, but these errors were encountered: