Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to view items in collection is broken due to FOLIO hrid prefixes #4581

Open
thatbudakguy opened this issue Feb 27, 2025 · 7 comments
Open
Labels

Comments

@thatbudakguy
Copy link
Member

This is evident with the Batchelor Map Collection (https://purl.stanford.edu/ct961sj2730):

The latter link seems to be using the prefixed version of the HRID (it starts with an a).

See also sul-dlss/purl#797

@andrewjbtw
Copy link

However, the link in the Roy Pryor collection record does work: https://purl.stanford.edu/ht919ys1747

Unless I'm missing something, it looks to me like SW may be indexing post-migration FOLIO records differently than pre-migration records. The Roy Pryor collection was created post-migration.

See also:

and presumably a number of other examples of released collections with folio HRIDs that were created post-FOLIO migration

@andrewjbtw
Copy link

There also appear to be cases where SW returns items in the collection only if the prefix is present.

Bay Area video arcades : photographs by Ira Nowinski, 1981-1982: https://purl.stanford.edu/sk882gx0113

That returns results, but removing the prefix leads to no results:

I found this example in a Slack thread from fall 2023, which is when we implemented the link.

It seems like the expectation back then was that SW would return results when including the prefix. But SW doesn't seem to be consistent one way or the other.

@thatbudakguy
Copy link
Member Author

hmm – maybe this is a problem on the SW side, then?

@thatbudakguy
Copy link
Member Author

moving this ticket to SW; maybe we can look at it during upcoming workcycle.

@thatbudakguy thatbudakguy transferred this issue from sul-dlss/purl Feb 27, 2025
@cbeer
Copy link
Member

cbeer commented Feb 27, 2025

Isn't this a PURL problem? There's logic here to handle the catalog ids: https://github.com/sul-dlss/purl/blob/04df4215f02e6731a38aeb6ef785d32dfc03aacf/app/models/public_xml.rb#L20

but that's not used for collection ids:
https://github.com/sul-dlss/purl/blob/main/app/models/public_xml.rb#L30

@andrewjbtw
Copy link

andrewjbtw commented Feb 27, 2025

See the examples above: sometimes SW returns results only with the prefix, sometimes only without the prefix.

Only with the prefix:

Only without the prefix:

Whichever logic purl should follow, one or the other case will fail for some collections.

@corylown
Copy link
Contributor

corylown commented Feb 28, 2025

The difference between "only works with prefix" and "only without the prefix" is that the items in the collection are in the former case SDR records and in the latter case they are FOLIO records.

So, I think Chris is right that this is purl problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants