Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony Deprecation. User Deprecated: The "quotes_repository" service is private, #12

Open
Sellato opened this issue Mar 6, 2018 · 1 comment

Comments

@Sellato
Copy link
Contributor

Sellato commented Mar 6, 2018

Hi!

I test your module, works fine, BUT get an error in Symfony Profiler:

Symfony Profiler:
User Deprecated: The "quotes_repository" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.

More info at https://symfony.com/blog/new-in-symfony-3-2-improved-private-services

Thanks

@carakas
Copy link
Contributor

carakas commented Mar 6, 2018

@Sellato can you create a PR for this? Shouldn't be too hard

Sellato added a commit to Sellato/fork-quotes that referenced this issue Mar 7, 2018
Try to fix error:

Symfony Deprecation. User Deprecated: The "quotes_repository" service is private.
carakas added a commit that referenced this issue Mar 7, 2018
Fix issue #12 Symfony Deprecation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants