Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-amz-acl missing for files <> Generic CDN Support #493

Open
2 tasks done
activenode opened this issue May 26, 2024 · 0 comments
Open
2 tasks done

x-amz-acl missing for files <> Generic CDN Support #493

activenode opened this issue May 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@activenode
Copy link

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Providers like DigitalOcean don't recursively apply 'x-amz-acl': 'public-read' even if the created bucket has that option applied. This means when using any other S3 provider, deep links to an public-read marked bucket won't work and result in Access Denied.

To Reproduce

Steps to reproduce:

  1. Create a Digital Ocean S3 Space and activate the CDN functionality
  2. Connect the S3 the standard way with by adapting the Docker config
  3. Create a public bucket and hence a public file within Supabase Studio
  4. Try to use the CDN deeplink to access the file: Access Denied

Expected behavior

File should be accessible by giving it the 'x-amz-acl': 'public-read' header on file level.

Important: Pitfalls

As one can change the bucket from being private to public and vise versa this header must be recursively added and removed when the bucket publicity changes.

Additional context

I wanted to implement this and found the respective files but in this one I'm not confident in pushing so I'm happy for a quick 15mins call (you can contact me in Slack).

@activenode activenode added the bug Something isn't working label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant