Convolution reverb

[blancoberg]

Describe the solution you'd like:
A convolution reverb in the effect lane.
This has already been discussed in surge discord, but though I could post it here as well as a reminder.

A convolution library that is potentially a candidate for this could be FFTConvolver:
https://github.com/HiFi-LoFi/FFTConvolver

[baconpaul]

The primary problem I’ve faced when thinking about this (because yes that fft convolver works well) is the workflow around saving loading managing and patch including the irs. (The second thing is ir sample rate mismatch but that’s fairly well understood).

Writing a good version of that workflow is the primary thing that’s stopped me from doing a cr with this lib

[mkruselj]

A lot of that workflow can be factored with Shortcircuit's missing content handling I think.

My main takeaway here is that IRs should not be embedded into the patch file by default. They can be larger than wavetables. This can and will easily bloat the size of patch banks. And so there should be a factory IR path, a user IR path, and a way to optionally embed IRs into the patch when saving (just like we do with tunings). Patches should also be able to reference the IRs through relative paths of course (especially in case of, say, no user IR path, relative path should then be taking the path of the patch as base).

But at that point, we might as well do the exact same thing with wavetables, as this would probably very much help in reducing the size of our factory bank (I bet a decent amount of patches share the same wavetables)...

[baconpaul]

I completely agree that if we had all of short-circuits missing resolution code available, finished, shared, and portable into surge, we could use that.

But that does make me wonder why you labeled this a Surge XT 1 milestone issue! :)

[mkruselj]

No specific XT1 release, easy to bump later as we see fit 😀