From d3f7ebaedd7f48c779375292d18d3f2cd6e8de25 Mon Sep 17 00:00:00 2001 From: Sunil Thaha Date: Fri, 13 Oct 2023 14:59:28 +1000 Subject: [PATCH] fix(exporter): do no enable estimated idle power by default (#276) The 'idle' value refers to the total host idle power, which is not distributed among all the running VMs on the node. Consequently, each VM may wrongly double-count the host's idle time if there are multiple VMs on the same host. In public cloud environments, it is impractical to determine the number of running VMs on a node. This parameter is intended for use only one bare metal servers that rely on node power estimation because they do not provide real-time power metrics, or when there is only one VM running on the host for very specific scenarios. So, lets enable this setting through Kepler spec (new feature). Ref: https://github.com/sustainable-computing-io/kepler/issues/973#issuecomment-1760680200 Signed-off-by: Sunil Thaha --- pkg/components/exporter/exporter.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/components/exporter/exporter.go b/pkg/components/exporter/exporter.go index efe0aba5..e2534bd3 100644 --- a/pkg/components/exporter/exporter.go +++ b/pkg/components/exporter/exporter.go @@ -138,7 +138,6 @@ func NewDaemonSet(detail components.Detail, k *v1alpha1.Kepler) *appsv1.DaemonSe "/usr/bin/kepler", "-address", bindAddress, "-enable-cgroup-id=true", - "-expose-estimated-idle-power=true", "-enable-gpu=$(ENABLE_GPU)", "-v=$(KEPLER_LOG_LEVEL)", "-kernel-source-dir=/usr/share/kepler/kernel_sources",