-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sv create with storybook fails from fresh minimal install #339
Comments
What version of Node.js are you using? |
v20.13.1 I tried the above setup at least 3 times with same result. tried: |
Can confirm, this also happens on node v22.11.0 Here is the full stack trace:
And the relevant code: import { defineMeta } from '@storybook/addon-svelte-csf';
import Button from './Button.svelte';
import { fn } from '@storybook/test';
// More on how to set up stories at: https://storybook.js.org/docs/writing-stories
const { Story } = defineMeta({
title: 'Example/Button',
component: Button,
tags: ['autodocs'],
argTypes: {
backgroundColor: { control: 'color' },
size: {
control: { type: 'select' },
options: ['small', 'medium', 'large'],
},
},
args: {
onClick: fn(),
}
}); Don't know how that tool is counting the lines, but looks like line 8 does not contain any Pinging @JReinhold. If you want me to create an issue, please let me know! |
Thanks for the report. This is unrelated to the I've opened an issue here where I explain what's going on: storybookjs/addon-svelte-csf#240 Feel free to close this one. |
I'm completely new to Storybook, so pressing that save button was almost my first interaction! How do we save changes then, without a Save button? |
@cristianvogel those changes in Controls are "saved" as See docs here: https://storybook.js.org/docs/writing-stories/args - remember to pick Svelte in the frameworks picker in the top. Feel free to DM me on Discord (Svelte or Storybook servers), I'm JReinhold 👋 |
npm run storybook
Then on an example button, I change the colour. Storybook says, do you want to save changes?
I say , yes (please)
It says
The text was updated successfully, but these errors were encountered: