Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remain nullable for pointer fields #44

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix: remain nullable for pointer fields #44

merged 1 commit into from
Sep 20, 2022

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Sep 20, 2022

fix: #43

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #44 (ff4c47f) into master (de8a401) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   41.05%   41.05%           
=======================================
  Files           5        5           
  Lines        3556     3556           
=======================================
  Hits         1460     1460           
  Misses       1802     1802           
  Partials      294      294
Flag Coverage Δ
unittests 41.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openapi3/reflect.go 86.07% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vearutop vearutop merged commit 6d8b47c into swaggest:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pointer primitives does not end up nullable
2 participants
@xobotyi @vearutop