Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update path param regex to have better tolerance and accuracy #46

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

vearutop
Copy link
Member

Fixes #45.

@github-actions
Copy link

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 7 (+1) 1281 (+2) 961 (+1) 60 (+1) 260 295 28.9K (+99B)
Go (test) 5 1583 (+37) 1155 (+32) 228 200 (+5) 21 (+2) 41.3K (+1.2K)
YAML 5 362 (+6) 297 (+6) 29 36 0 11.4K (+192B)

@github-actions
Copy link

Unit Test Coverage

total: (statements) 48.9%

Coverage of changed lines

No changes in testable statements.

Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 48.9% 48.9% (0.0%)
github.com/swaggest/openapi-go/openapi3/helper.go SetupOperation 91.9% 94.6% (+2.7%)

@github-actions
Copy link

Go API Changes

# summary
Inferred base version: v0.2.21
Suggested version: v0.2.22

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #46 (3ef390c) into master (6d8b47c) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   41.05%   41.11%   +0.05%     
==========================================
  Files           5        5              
  Lines        3556     3556              
==========================================
+ Hits         1460     1462       +2     
+ Misses       1802     1801       -1     
+ Partials      294      293       -1     
Flag Coverage Δ
unittests 41.11% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openapi3/helper.go 90.74% <ø> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vearutop vearutop merged commit ba4394c into master Sep 27, 2022
@vearutop vearutop deleted the path-param-matching branch September 27, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the regular expression used to remove gorilla.mux-style regexp in paths
1 participant