Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of http bearer scheme #52

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Nov 14, 2022

Fixes #51.

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go (gen) 1 8582 (+24) 5895 (+16) 720 (+1) 1967 (+7) 1252 (+6) 190.6K (+542B)
Go (gen) (test) 1 1061 832 1 228 0 31.4K (+3B)
Go (test) 6 (+1) 1694 (+50) 1251 (+45) 229 214 (+5) 21 43.9K (+967B)

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Go API Changes

# github.com/swaggest/openapi-go/openapi3
## compatible changes
(*NonBearer).UnmarshalJSON: added
(*Reflector).InlineDefinition: added

# summary
Inferred base version: v0.2.24
Suggested version: v0.3.0

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Unit Test Coverage

total: (statements) 49.6%
changed lines: (statements) 81.8%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 81.8%
openapi3/entities.go 81.8%
openapi3/entities.go:6796 UnmarshalJSON 92.0%
Coverage diff with base branch

No changes in coverage.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #52 (d50b591) into master (b0eb17d) will increase coverage by 0.79%.
The diff coverage is 77.77%.

❗ Current head d50b591 differs from pull request most recent head 9f68bd8. Consider uploading reports for the commit 9f68bd8 to get more accurate results

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   41.16%   41.95%   +0.79%     
==========================================
  Files           5        5              
  Lines        3559     3568       +9     
==========================================
+ Hits         1465     1497      +32     
+ Misses       1801     1783      -18     
+ Partials      293      288       -5     
Flag Coverage Δ
unittests 41.95% <77.77%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openapi3/entities.go 35.27% <77.77%> (+0.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vearutop vearutop merged commit c38df69 into master Nov 14, 2022
@vearutop vearutop deleted the non-bearer-validation branch November 14, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security schemes validation error
1 participant