Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Currency Converter #1728

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

eiva078
Copy link
Contributor

@eiva078 eiva078 commented Jun 11, 2024

πŸ› οΈ Fixes Issue (#1684 )

πŸ‘¨β€πŸ’» Changes proposed and Brief Description

Incorporate images for each currency flags and conversion arrows.
Optimize the layout for various devices, ensuring a seamless experience on desktops, tablets, and smartphones.

βœ… Check List (Check all the applicable boxes)

  • My code doesn't break any part of the project
  • This PR does not contain plagiarized content.
  • My Addition/Changes works properly and matches the overall repo pattern.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

@swapnilsparsh please assign the labels and levels

πŸ“· Screenshots

Screenshot 2024-06-11 114222

for tablets
Screenshot 2024-06-11 114250

for smartphones
Screenshot 2024-06-11 132613

with the help of exchange symbol it can be swapped...
Screenshot 2024-06-11 115255

Copy link

netlify bot commented Jun 11, 2024

βœ… Deploy Preview for 30daysofjs ready!

Name Link
πŸ”¨ Latest commit 9657a00
πŸ” Latest deploy log https://app.netlify.com/sites/30daysofjs/deploys/666803f22501e0000809404b
😎 Deploy Preview https://deploy-preview-1728--30daysofjs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swapnilsparsh swapnilsparsh merged commit f4b28a5 into swapnilsparsh:master Jun 14, 2024
4 checks passed
@swapnilsparsh
Copy link
Owner

@eiva078 Thank you for contributing to this repo. Looking forward for more πŸš€

@swapnilsparsh swapnilsparsh added gssoc GirlScript Summer of Code 2024 level2 Medium labels Jun 14, 2024
@eiva078
Copy link
Contributor Author

eiva078 commented Jun 14, 2024

@eiva078 Thank you for contributing to this repo. Looking forward for more πŸš€

@swapnilsparsh sir, please assign this PR also to me...

@eiva078
Copy link
Contributor Author

eiva078 commented Jun 23, 2024

@swapnilsparsh sir whatever changes I have made in currency converter it got removed could you please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GirlScript Summer of Code 2024 level2 Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants