Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password without username not handled correctly #19

Open
AndreasA opened this issue Jan 26, 2015 · 3 comments
Open

Password without username not handled correctly #19

AndreasA opened this issue Jan 26, 2015 · 3 comments

Comments

@AndreasA
Copy link

If I have a password without a username it is not handled correctly.
1.) If there is a stored login with a username in the stored passwords, that password will be used when retrieving one.
2.) If there has been no username/password combination before storing the password, that password will automatically also be used for username/password prompts (which does not make sense because there is a username to be entered too).

The first is not that big a problem.
The second, however, is more problamtic because I seem to be unable to store the password then with the username (might only be a problem if the password is the same as without the username)

@swick
Copy link
Owner

swick commented Apr 9, 2015

Do you have the same problem with the default password manager? The extension doesn't do any username checking when retrieving or storing passwords, it only stores what firefox gives us.

@AndreasA
Copy link
Author

AndreasA commented Apr 9, 2015

Will have to test this but I once I am on the workstation where I have set this up.
Possibly tomorrow.

@infinity0
Copy link
Contributor

I believe this bug probably exists in the binary version as well. I am guessing the cause is that the binary API treats empty username as "match everything" when retrieving the password again. So we probably need to use a magic value in place for empty usernames, but it's unclear which magic value would be suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants