-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve snippets #25
base: main
Are you sure you want to change the base?
Improve snippets #25
Conversation
tib
commented
Jan 13, 2025
•
edited
Loading
edited
- update snippets location, group by year
- fix protobuf & grpc snippets
- fix jwt-kit snippet location
- fixes Fix gRPC snippets #21
Seems like CI failed, but swiftinit was able to locate the snippets. |
this looks like the same issue @sebsto ran into yesterday |
Also I've noticed, that the snippets are working on swiftinit, but the path seems to be incorrect, taken this example the path should contain
The rendered snippet in the article looks just fine: link This is a strange behavior, what's the correct approach here? @tayloraswift +1: What's |
as described here, the the way Snippets are implemented in SwiftPM, each Snippet is a module, so all Snippets share a global namespace within a build tree. Snippet names also undergo module name mangling, so Snippets whose names differ in special characters only will still collide from SwiftPM’s perspective. the first component ( this has a lot of weird implications, the first being that if the package name contains special characters (like spaces), i recommend using |
What do you think @Joannis are you fine with migrating to IDs instead of paths? I'm happy to do the changes, Snippets never really worked with DocC when using Xcode anyway... we always use unidoc to render them, so it makes sense imho. |
I'm completely convinced we should drop Xcode's DocC. Right now we have no way to view updated text quickly through swiftinit's rendering system. So it's a bit of a guessing game requiring many rerenders to get the desired result. |
is the |
I'll give it a try & update all the path-s to ids to see how it works & looks like. |