Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect documentation for "will" #161

Open
Cyberbeni opened this issue Oct 31, 2024 · 1 comment
Open

Incorrect documentation for "will" #161

Cyberbeni opened this issue Oct 31, 2024 · 1 comment

Comments

@Cyberbeni
Copy link
Contributor

At multiple places in the documentation comments it is stated that the will is sent as soon as we are connected. According to the RFC, the will is sent when we are disconnecting without sending a DISCONNECT packet with reason code 0: https://datatracker.ietf.org/doc/html/rfc9431#section-1.3-4.24.1

The behaviour is correct (as we are just sending the information in the CONNECT packet and the broker is handling it), it's just the documentation that is incorrect.
@adam-fowler
Copy link
Collaborator

I'd be happy to accept a PR to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cyberbeni @adam-fowler