From 83062fa276c05745f4d336a483447e483b794d3e Mon Sep 17 00:00:00 2001
From: Saleem Abdulrasool <abdulras@thebrowser.company>
Date: Sat, 7 Sep 2024 21:02:21 -0700
Subject: [PATCH] Tests: prefer `XCTAssertEqual` over `XCTAssertTrue`

Use the `XCTAssertEqual` check for the equality over an inline equal
check. This allows the message to describe both sides of the comparison
and helps identify the issue more easily.
---
 Tests/Foundation/TestXMLDocument.swift | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Tests/Foundation/TestXMLDocument.swift b/Tests/Foundation/TestXMLDocument.swift
index 2f9eaaab9e..2db981dca4 100644
--- a/Tests/Foundation/TestXMLDocument.swift
+++ b/Tests/Foundation/TestXMLDocument.swift
@@ -27,16 +27,16 @@ class TestXMLDocument : LoopbackServerTest {
         XCTAssert(element.name! == "D:propfind")
         XCTAssert(element.rootDocument == nil)
         if let namespace = element.namespaces?.first {
-            XCTAssert(namespace.prefix == "D")
-            XCTAssert(namespace.stringValue == "DAV:")
+            XCTAssertEqual(namespace.prefix, "D")
+            XCTAssertEqual(namespace.stringValue, "DAV:")
         } else {
             XCTFail("Namespace was not parsed correctly")
         }
         
         if let child = element.elements(forName: "D:prop").first {
-            XCTAssert(child.localName == "prop")
-            XCTAssert(child.prefix == "D")
-            XCTAssert(child.name == "D:prop")
+            XCTAssertEqual(child.localName, "prop")
+            XCTAssertEqual(child.prefix, "D")
+            XCTAssertEqual(child.name, "D:prop")
         } else {
             XCTFail("Child element was not parsed correctly!")
         }
@@ -484,8 +484,8 @@ class TestXMLDocument : LoopbackServerTest {
         let elementDecl = XMLDTDNode(kind: .elementDeclaration)
         elementDecl.name = "MyElement"
         elementDecl.stringValue = "(#PCDATA | array)*"
-        XCTAssert(elementDecl.stringValue == "(#PCDATA | array)*", elementDecl.stringValue ?? "nil string value")
-        XCTAssert(elementDecl.name == "MyElement")
+        XCTAssertEqual(elementDecl.stringValue, "(#PCDATA | array)*")
+        XCTAssertEqual(elementDecl.name, "MyElement")
     }
 
     func test_documentWithDTD() throws {
@@ -562,9 +562,9 @@ class TestXMLDocument : LoopbackServerTest {
         XCTAssert(newNS.name == "F")
         
         let root = doc.rootElement()!
-        XCTAssert(root.localName == "propfind")
-        XCTAssert(root.name == "D:propfind")
-        XCTAssert(root.prefix == "D")
+        XCTAssertEqual(root.localName, "propfind")
+        XCTAssertEqual(root.name, "D:propfind")
+        XCTAssertEqual(root.prefix, "D")
         let node = doc.findFirstChild(named: "prop")
         XCTAssert(node != nil, "failed to find existing node")
         XCTAssert(node?.localName == "prop")