Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: --main-header-height property in post-header is undefinedpx #4564

Closed
Tracked by #4561
alionazherdetska opened this issue Jan 30, 2025 · 0 comments · Fixed by #4614
Closed
Tracked by #4561

[bug]: --main-header-height property in post-header is undefinedpx #4564

alionazherdetska opened this issue Jan 30, 2025 · 0 comments · Fixed by #4614
Assignees
@alionazherdetska
Labels
🐞 bug Something isn't working Header Everything related to our composible header components
Milestone
PPNL Support

Comments

@alionazherdetska
Copy link
Contributor

alionazherdetska commented Jan 30, 2025 •
edited
Loading

Description:
The CSS custom property --main-header-height is undefined.

Steps to Reproduce:

  1. Open the Header page.
  2. Inspect the post-header.
  3. Observe that --main-header-height is undefined.
--main-header-height.mp4
@alionazherdetska alionazherdetska added Header Everything related to our composible header components 🐞 bug Something isn't working labels Jan 30, 2025
@alionazherdetska alionazherdetska changed the title [bug]: [bug]: --header-scroll-top variable not updating on scroll Jan 30, 2025
@gfellerph gfellerph added this to the PPNL Support milestone Jan 31, 2025
@alionazherdetska alionazherdetska changed the title [bug]: --header-scroll-top variable not updating on scroll [bug]: --main-header-height property in post-header is undefinedpx Feb 4, 2025
@gfellerph gfellerph mentioned this issue Feb 5, 2025
Open
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Feb 5, 2025
@alionazherdetska alionazherdetska self-assigned this Feb 5, 2025
@alionazherdetska alionazherdetska linked a pull request Feb 5, 2025 that will close this issue
fix(component): set --main-header-height for post-header on component load #4614
Merged
@alionazherdetska alionazherdetska moved this from 💻 Ready for development to 🤬 Dev in Code Review in Design System Production Board Feb 5, 2025
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alionazherdetska alionazherdetska

Labels
🐞 bug Something isn't working Header Everything related to our composible header components
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

fix(component): set --main-header-height for post-header on component load swisspost/design-system
2 participants
@gfellerph @alionazherdetska