Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core tokens from the header components #4530

Open
Tracked by #4561
oliverschuerch opened this issue Jan 27, 2025 · 0 comments · May be fixed by #4657
Open
Tracked by #4561

Remove core tokens from the header components #4530

oliverschuerch opened this issue Jan 27, 2025 · 0 comments · May be fixed by #4657
Assignees
Labels
Header Everything related to our composible header components 📦 styles Related to the @swisspost/design-system-styles package

Comments

@oliverschuerch
Copy link
Contributor

oliverschuerch commented Jan 27, 2025

We should use core tokens directly in our scss files.
Instead, we can replace them by utility tokens, use existing sass variables (for example for colors) or create component specific css-variables for props that change on the client (for example from breakpoint to breakpoint) or create sass variables for props, that stay static on the client.

When possible we could also use the utility tokens: #4273 (comment)

@oliverschuerch oliverschuerch added Header Everything related to our composible header components 📦 styles Related to the @swisspost/design-system-styles package labels Jan 27, 2025
@oliverschuerch oliverschuerch added this to the Maintenance III milestone Jan 27, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Jan 29, 2025
@leagrdv leagrdv self-assigned this Feb 11, 2025
@leagrdv leagrdv moved this from 💻 Ready for development to 🤬 Dev in Code Review in Design System Production Board Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Header Everything related to our composible header components 📦 styles Related to the @swisspost/design-system-styles package
Projects
Status: 🤬 Dev in Code Review
Development

Successfully merging a pull request may close this issue.

2 participants