[LC] createForm() in ComponentWithFormTrait

[Nayte91]

Hello,

Just a thought as I browsed the doc at the form part, and it seems that currently to use forms you have to extend AbstractController and use ComponentWithFormTrait.

I checked my usecases, and it seems that the only reason why I need AbstractController extended, is for its createForm() method.

So I wonder if it's possible to "inject" FormFactoryInterface into ComponentWithFormTrait to make the same method, and therefore diminish the need of AbstractController inheritance? I looked at how LC traits are built, and I didn't understand how services are served into properties, but they definitely are.

So one may need AbstractController for other use cases, but for this one, that's a nice saving!

Sorry if it was naive, happy new year everyone and long live UX!

[norkunas]

Hi,

For sure you can inject form factory through constructor and use it. I never extend AbstractController :)

[Nayte91]

Thank you for your insight, Happy to know that there is not an hidden reason for that!

So I'm scanning the code, and I'm not very good, but I'm wondering how to "inject" the FormFactoryInterface into a LC Trait:

• Traits cannot use a constructor, or launch the "user" constructor,
• LC or LC Traits don't have access to the Container, getContainer(), or any way to inject a given service...
• ...Unless you design a #[LiveAction] where you can inject a service as a parameter, like on SF's controllers.

I feel like the road will be this last point, but it would need at the very least:

1. To create a new attribute, something like #[LiveInject] or whatever, to keep the injection superpower (but I didn't find how it's done actually), but remove the #[LiveAction]'s reRender part,
2. To revamp the abstract InstantiateForm() method, to find another way to catch the parameters for the FormFactoryInterface::createForm(string $type, mixed $data = null, array $options = []). So something like InstantiateForm(string $type, mixed $data = null, array $options = []) that will invoke createForm() and stock the FormInterface object on its side. But I don't really see how to do,
3. BC break by changing the behavior of this method, at least, along with number of problems I didn't see. So to do in 2.x to have it in 3.x

I'm a little bit stuck with my researches, thanks to my poor ability to understanding the LC code. Any hint about if my implementation idea is a dead end or not, and where to look at in src/ ?

[smnandre]

You can inject in the constructor :)

[Nayte91]

Yes, I know how to inject on my codebase side; The question is more: on the Symfony UX POV, is there a way for this ComponentWithFormTrait to carry all the needed stuff without relying on AbstractController? And the answer for that is: it can be cool for global DX (and a bit of perfs) if the FormFactoryInterface puzzle can be solved.

Do you kind of agree that Freeing ComponentWithFormTrait from AbstractController necessity would be a benefit? Otherwise there is no point to look further :)

• perfs as AbstractController is heavier than FormFactoryInterface alone,
• DX as having to "import" twice ('use' and 'extend') for 1 behavior can be deceptive and error prone
• uncoupling (a little bit) of LC with regular SF controllers

Here's my naive arguments. But if costs of embedding FFI in trait overcomes the benefits, it's not the good way (maybe a AbstractLiveController that embedd the trait methods?)

[norkunas]

As I said, there is no need for AbstractController, implement the instantiateForm method using your injected formFactory and that's all

[Nayte91]

Ok