Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify generator logic #131

Open
ioleo opened this issue Apr 12, 2015 · 1 comment
Open

Simplify generator logic #131

ioleo opened this issue Apr 12, 2015 · 1 comment
Assignees

Comments

@ioleo
Copy link
Member

ioleo commented Apr 12, 2015

Currently some processes are unnecessarily complicated. We're getting a admingenerator.generator.doctrine service, which is injected with some stuff.. only to pass it to other classes, which are instantiated with new Classname.

Instead, we should create new (non public) services for these classes and inject the right dependencies directly where they are needed (eg. into builders).

This should clean up much of the duplicated code and simplify the bundle internals.

@ioleo
Copy link
Member Author

ioleo commented Apr 12, 2015

Create a dedicated class with static method getFromArray and use it across all classes (reduce code duplication).

@ioleo ioleo self-assigned this Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant