-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Sort By" is wrong on edit page #8
Comments
Hey @michael-e, can you provide a little more detail? I haven't been able to reproduce in Firefox, Chrome or Safari :( |
I have verified the following with Safari (latest) and Firefox (latest) on my Mac: Initial state:
Add first Datasource (Sort by: Date; Sort Order: descending). Result:
(Sometimes "descending" is displayed, but I haven't found any logic behind this.) Now save the Union DS. Result:
|
Is this with the latest from master? |
Yes, tagged 0.6. |
Hey @michael-e, can reproduce some of it (the Sort Order, not the Sort By column). Think I've fixed it up within 8c64a08, can you test? |
One step. It works during editing now, but it's still wrong after the Union DS has been saved. |
Hmm, head scratch. Will have to have another dig around! |
I think I finally fixed this on the |
I cherry-picked that commit, cause I am still on 2.2.5. Nope, doesn't seem to work. Perhaps some conflict? |
On the edit page, the inactive
sort by
andsort order
dropdowns don't show the right items. (On the index page, however, theorder by
column contains correct values.)The text was updated successfully, but these errors were encountered: