Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sort By" is wrong on edit page #8

Open
michael-e opened this issue Jan 27, 2012 · 9 comments
Open

"Sort By" is wrong on edit page #8

michael-e opened this issue Jan 27, 2012 · 9 comments

Comments

@michael-e
Copy link
Member

On the edit page, the inactive sort by and sort order dropdowns don't show the right items. (On the index page, however, the order by column contains correct values.)

@brendo
Copy link
Member

brendo commented Feb 3, 2012

Hey @michael-e, can you provide a little more detail?

I haven't been able to reproduce in Firefox, Chrome or Safari :(

@michael-e
Copy link
Member Author

I have verified the following with Safari (latest) and Firefox (latest) on my Mac:

Initial state:

  • Sort By: ---
  • Sort Order: ascending

Add first Datasource (Sort by: Date; Sort Order: descending). Result:

  • Sort By: Date
  • Sort Order: ascending (which is wrong)

(Sometimes "descending" is displayed, but I haven't found any logic behind this.)

Now save the Union DS. Result:

  • Sort By: position (a field which does not even exist in the DS's section)
  • Sort Order: descending (correct!)

@brendo
Copy link
Member

brendo commented Feb 3, 2012

Is this with the latest from master?

@michael-e
Copy link
Member Author

Yes, tagged 0.6.

brendo added a commit that referenced this issue Feb 3, 2012
@brendo
Copy link
Member

brendo commented Feb 3, 2012

Hey @michael-e, can reproduce some of it (the Sort Order, not the Sort By column). Think I've fixed it up within 8c64a08, can you test?

@michael-e
Copy link
Member Author

One step. It works during editing now, but it's still wrong after the Union DS has been saved.

@brendo
Copy link
Member

brendo commented Feb 7, 2012

Hmm, head scratch. Will have to have another dig around!

@brendo
Copy link
Member

brendo commented Jun 5, 2012

I think I finally fixed this on the integration branch :)

@michael-e
Copy link
Member Author

I cherry-picked that commit, cause I am still on 2.2.5. Nope, doesn't seem to work. Perhaps some conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants