no-piggyback-errors #145
Open
no-piggyback-errors #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zsolt Gyulai (zgyulai) <[email protected]>
bazsi
reviewed
Oct 2, 2024
| @@ -139,5 +139,6 @@ | |||
| If the BOM[^1] character is missing, but the message is otherwise UTF-8 | |||
| compliant, {{ site.product.short_name }} automatically adds the BOM character to the | |||
| message. | |||
| - *no-piggyback-errors*: This option configures syslog-ng OSE to ignore parsing errors caused by piggybacked messages. If the parser encounters issues separating multiple messages sent together, it skips them without raising an error. | |||
There was a problem hiding this comment.
This description does not make much sense to me.
There was a problem hiding this comment.
@zsoltgyulai94 could you please check this PR description and rephrase based on it, TIA!
There was a problem hiding this comment.
Yeah, sorry, wasn't aware of that PR. Fixed.
Signed-off-by: Zsolt Gyulai (zgyulai) <[email protected]>
bazsi
reviewed
Oct 7, 2024
| @@ -139,5 +139,7 @@ | |||
| If the BOM[^1] character is missing, but the message is otherwise UTF-8 | |||
| compliant, {{ site.product.short_name }} automatically adds the BOM character to the | |||
| message. | |||
| - *no-piggyback-errors*: On failure, the original message will be left as it was before parsing, the value of `$MSGFORMAT` will be set to `syslog-error`, and a tag will be placed on the message corresponding to the parser's failure. | |||
There was a problem hiding this comment.
it is syslog:error not syslog-error.
the tags the parser can add to the message could also be referenced
tags. Signed-off-by: Zsolt Gyulai (zgyulai) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "no-piggyback-errors" to parser flags.
Signed-off-by: Zsolt Gyulai (zgyulai) [email protected]