-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interface windows support #51
Comments
@mrmbernardi Thanks for pointing out the issue. I've changed the return to win32 from Windows. Have you tried the methods mentioned in this thread? #5 (comment) |
Yes, when build with MSYS2, UCRT64, and G++, I get library not found errors from python (this is the error when the library is found but cannot be loaded for another reason). If I build with MsBuild, the library is successfully loaded but the names are not mangled correctly. |
@mrmbernardi Just to clarify, the executable can run on Win but the Python binding has problems, right? |
When I build MsBuild, the executable works. If I build with MSYS UCRT, I get an entry point not found error. |
Windows support is alluded to on this line:
SZ3/tools/pysz/pysz.py
Line 21 in e78f483
However it doesn't work since
sys.platform
returnswin32
for Windows, notwindows
.I have tried to use Sz3 through python on windows by patching this bug and building SZ3c with G++ and with MsBuild, but no matter what I tried I couldn't get it to work properly.
Perhaps to interface with python properly, it needs to be built with MsBuild and the functions need to be defined properly with
__declspec
like here:SZ3/tools/zstd/zstd.h
Line 31 in e78f483
The text was updated successfully, but these errors were encountered: