New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints that access twitter API should return a 5xx status code if the twitter api keys are not properly set #48

Open

german1608 opened this issue Jun 25, 2020 · 0 comments

Labels

enhancement good first issue

Member

german1608 commented Jun 25, 2020

As an enhancement, the following endpoitns should return a 5xx status code (I suggest 503) when the twitter api keys are not properly configured.

There are two approaches for this:

The naive implementation could just check for the twitter access keys environmental variables in our code and check if they are empty, raising the 5xx error if so.
A good implementation could be to handle the twitter api errors and check what error tell us if the secret keys were not properly set, and show a better error (not the traceback of the twitter response) explaining why did that happened.

I'd encourage whoever is going to do this to use the later.

german1608 added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment