Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning running the test #1

Open
m-onz opened this issue Nov 26, 2018 · 4 comments
Open

warning running the test #1

m-onz opened this issue Nov 26, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@m-onz
Copy link

m-onz commented Nov 26, 2018

hey,

Great library.. i was just running the tests on ubuntu 18 and I get streaming warnings until I stop the test. Do the tests work on other operating systems? I will continue to investigate

(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68337 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68338 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68339 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68338 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) War^C
@t-mullen
Copy link
Owner

t-mullen commented Nov 27, 2018

Seems like it's a bug in nanobus (the event library used): choojs/nanobus#32

Looks like the fix is to disable the nanotiming API or upgrade Node. :/

Should swap out nanobus for the native EventEmitter when running in Node.

@t-mullen t-mullen added the bug Something isn't working label Nov 27, 2018
@m-onz
Copy link
Author

m-onz commented Nov 27, 2018

Ok Thanks for the heads up. I will investigate those options and try and put in a PR.

@m-onz
Copy link
Author

m-onz commented Nov 27, 2018

Also I plan to make an experiment using streams + webRTC... i think it should be straight foward to make a duplex stream for the message passing similar to https://github.com/dominictarr/scuttlebutt. I'll report back when I have some findings!

@t-mullen
Copy link
Owner

t-mullen commented Dec 3, 2018

It's definitely possible to stream. The reason I didn't go with that approach is because readable-stream is such a large dependency and it's easy enough to wrap this module with a stream.

If you're going with Node.js-only, then you wouldn't really care about dependency size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants