New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the remoteAddr being logged is the client IP used by the rate limiter #598

Open

tux93 opened this issue Jul 22, 2024 · 0 comments

Labels

bug t&s

tux93 commented Jul 22, 2024

Quoting from Matrix:

TravisR|09:00 PM
the remote address appears to be added to the log context before the rate limiter, so it's possible that it's just not logging the value at all
David|09:02 PM
So what gets logged as remoteAddr is not what the rate limiter uses?
TravisR|09:02 PM
correct
it would be a bug, if you'd like to open an issue

turt2live added bug t&s labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment