Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop support #23

Open
t3dotgg opened this issue Nov 10, 2024 · 6 comments
Open

Drag and drop support #23

t3dotgg opened this issue Nov 10, 2024 · 6 comments

Comments

@t3dotgg
Copy link
Owner

t3dotgg commented Nov 10, 2024

Saw a bunch of PRs for this and none quite do what I want, so figured cutting this to describe it would be easiest.

Expectations

  • No third party libs (I have trauma around react-dropzone, we forked it for UploadThing)
  • Logic reused across three tools
  • "Full page dropzone" (I can drop anywhere)
  • Dropping images still works when one is currently open (dropzone should always work)
  • NO CHANGING CURRENT BEHAVIOR (leave the label/button as is)
@Bashamega
Copy link

Hello:)

I would like to work on that.

I would create a component called Uploader which all be in all tools and it will have all the design and drop things.

@vys69
Copy link
Contributor

vys69 commented Nov 10, 2024

Hello:)

I would like to work on that.

I would create a component called Uploader which all be in all tools and it will have all the design and drop things.

#10

@Bashamega
Copy link

Should i work on it?

philipbrembeck added a commit to philipbrembeck/quickpic that referenced this issue Nov 10, 2024
@Rana-Faraz
Copy link

  • Made a Provider component that wraps the tools and takes the ref of that input to manage drag and drop on whole page.
  • No library, No logic changes, Previous label/button works like it used to.
  • Had to move the input out of the conditional render to allow the user to drop a new image on top of the previous image.

PR: #34

@Bashamega
Copy link

This issue is solved in #62

@vys69
Copy link
Contributor

vys69 commented Nov 13, 2024

Close issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants