-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept proxy setting in tabpy-deploy-models #467
Labels
Comments
@ElPincheTopo Yes, the team behind TabPy would love any improvements! |
ElPincheTopo
added a commit
to ElPincheTopo/TabPy
that referenced
this issue
Jan 14, 2021
Add convenience function for building the config dict
ElPincheTopo
added a commit
to ElPincheTopo/TabPy
that referenced
this issue
Jan 14, 2021
Allow to modify the NLTK download path and proxy settings via the tabpy config file.
ElPincheTopo
added a commit
to ElPincheTopo/TabPy
that referenced
this issue
Jan 14, 2021
I submitted a pull request with my proposed changes: #471 |
It's taken some time, but we are reviewing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tabpy-deploy-models
runsSentimentAnalysis.py
which runs:This fails if you are running in environments without direct connection to the internet. nltk supports setting a proxy for the downloads, so I propose adding a cmd line argument to pass the proxy address to
tabpy-deploy-models
and this would pass it to all the scripts in case any other script needs it. For now, onlySentimentAnalysis.py
and we just need to get the cmd arg pass it tonltk.set_proxy()
.I'm happy to do this but I would like to know if the team behind TabPy likes the approach and would accept my Pull request.
The text was updated successfully, but these errors were encountered: