You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue occurs while populating the permissions, as _set_default_permissions function tries to set the attribute _default_virtualConnection_permissions instead of _default_virtualconnection_permissions
Describe the bug
In #1463 I've added support for virtual connection project permissions. I've now realized that they don't work.
Default virtualconnection permissions have been defined in project_item as follows:
While populating permissions, we use Resource.VirtualConection referencing models/tableau_types
Issue occurs while populating the permissions, as
_set_default_permissions
function tries to set the attribute_default_virtualConnection_permissions
instead of_default_virtualconnection_permissions
Possible solutions:
virtualConnection
definition in models/tableau_types.py tovirtualconnection
- could this be a breaking change for sth?default_virtualconnection_permissions
todefault_virtualConnection_permissions
- snake case / camel case hybrid? not a good lookattr = f"_default_{content_type}_permissions"
so it uses only lowercaseI've created the issue instead of directly raising a PR as I am not sure which one of these changes would be prefered
The text was updated successfully, but these errors were encountered: