Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOT-47] Remove configurable MaxRowCount #434

Open
dtbuchholz opened this issue Jan 17, 2023 · 0 comments
Open

[GOT-47] Remove configurable MaxRowCount #434

dtbuchholz opened this issue Jan 17, 2023 · 0 comments
Labels
enhancement New feature or request linear Sync issue with linear

Comments

@dtbuchholz
Copy link
Contributor

dtbuchholz commented Jan 17, 2023

Since the maximum number of rows is a protocol definition and cannot be configured by an indiviual validator, the TableContraints > MaxRowCount key/value should be removed from the following:

As noted by @jsign:

For example, if the limit is X and a table has X rows, then a further insertion will make the query fail (as defined in the spec).
If someone bumps that X, then that query won't fail and they'll "fork" from the rest of the network.

GOT-47

@dtbuchholz dtbuchholz added the enhancement New feature or request label Jan 17, 2023
@brunocalza brunocalza added the linear Sync issue with linear label Mar 23, 2023
@brunocalza brunocalza changed the title Remove configurable MaxRowCount [GOT-47] Remove configurable MaxRowCount Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linear Sync issue with linear
Projects
None yet
Development

No branches or pull requests

2 participants