Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox firing select value onChange when clearing the input value #3534

Open
david10sing opened this issue Oct 17, 2024 · 0 comments
Open

Combobox firing select value onChange when clearing the input value #3534

david10sing opened this issue Oct 17, 2024 · 0 comments

Comments

@david10sing
Copy link

david10sing commented Oct 17, 2024 •
edited
Loading

headlessui/packages/@headlessui-react/src/components/combobox/combobox.tsx

Line 1309 in 5eb3b12

clear()

Based on the line above and the preceding comment, it looks like when the user clears the input value, there is an onChange event fired.

Is there a reason for this? I would have thought that the input value and the selected option concerns should be different.

Why would we want to trigger an onChange and send null when the user is just typing and clearing the input field?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@david10sing