Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating panel blur area too large #24

Closed
bradrjohns opened this issue Mar 19, 2024 · 8 comments
Closed

Floating panel blur area too large #24

bradrjohns opened this issue Mar 19, 2024 · 8 comments
Labels
0. type: bug Something isn't working

Comments

@bradrjohns
Copy link

Around floating panels, the blur region extends too far by maybe 10 pixels and is rectangular in shape
Screenshot_20240319_160837
Screenshot_20240319_160815

@taj-ny
Copy link
Owner

taj-ny commented Mar 19, 2024

Floating panels have a transparent border that is part of the window, so I don't think there's a way to fix this. Why do you need to force blur plasmashell?

@bradrjohns
Copy link
Author

I have plasmashell windows set to 100% opacity currently, and the larger blur region is still present around the panels. Not sure if there is a setting I am missing other than window rules that could be force blurring plasmashell? I also tried non-blur plasma styles but that didn't have an effect.

With the default KDE blur effect (see attached), I am not seeing the issue though:
Screenshot_20240319_165231

PS- really appreciate all the work you've done with this!

@queenbiscuit311
Copy link

I don't seem to have this at all. Maybe something weird with your configuration or theme?

image

image

@taj-ny
Copy link
Owner

taj-ny commented Mar 20, 2024

@bradrjohns Send a screenshot of the force blur effect configuration.

@bradrjohns
Copy link
Author

I went to take a screenshot, and realized I had previously toggled on "blur all except matching" and did include plasmashell as an exception. When I added plasmashell, the larger blur region was no longer an issue. The only downside is now I don't have blur for plasmashell menus or windows, but that is very minor.
image

@taj-ny
Copy link
Owner

taj-ny commented Mar 20, 2024

The only downside is now I don't have blur for plasmashell menus or windows, but that is very minor.

This won't be an issue anymore when #25 is implemented. It'll also include the option to only match certain window types, so you'll be able to blur plasmashell menus without blurring the docks.

@taj-ny taj-ny closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@taj-ny taj-ny reopened this Mar 20, 2024
@taj-ny
Copy link
Owner

taj-ny commented Mar 20, 2024

Since panels don't need to be forcefully blurred, I disabled that on the develop branch.

@taj-ny taj-ny added the 0. type: bug Something isn't working label Mar 20, 2024
@taj-ny taj-ny closed this as completed in 65345df Mar 22, 2024
@taj-ny
Copy link
Owner

taj-ny commented Mar 22, 2024

Fixed in v1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants