-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: race local builds against remotes #439
Open
m-hilgendorf
wants to merge
19
commits into
main
Choose a base branch
from
feat/race-builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
m-hilgendorf
commented
Jan 14, 2025
- resolves Create a build in build_target while waiting for existing remote builds #434
m-hilgendorf
commented
Jan 14, 2025
packages/server/src/target/build.rs
Outdated
let output = tg::target::build::Output { build: build_id }; | ||
|
||
Ok(Some(output)) | ||
Ok(Some(build)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to wait for the build to be spawned here, or just let it win?
wip: rename and run args wip: rename Target -> Command in typescript wip: runtime wip: add cwd/network args to command, update v8/runtime wip: update cli wip: server compiling wip: complete rename, compiling packages wip: update runtimes to use tg::process::Id and server methods directly
- resolves #434
m-hilgendorf
force-pushed
the
feat/race-builds
branch
from
January 23, 2025 20:54
0e730ee
to
38b1b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.