Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile unclear about dependancies #122

Open
DarkWiiPlayer opened this issue May 29, 2019 · 1 comment
Open

Makefile unclear about dependancies #122

DarkWiiPlayer opened this issue May 29, 2019 · 1 comment
Labels
need feedback question Further information is requested

Comments

@DarkWiiPlayer
Copy link

I just spent about 30 minutes figuring out how to add this module to nginx, and it seems the fix was that I needed to make yajl and make msgpack within the module directory before compiling nginx/openresty.

The readme does mention that these are needed; however it does not tell you that they aren't actually being built, causing an error, and you have to build them manually.

I find this quite unintuitive and believe that the readme should mention this to spare future users having to find it out for themselves.

Currently my installation process looks about like this:

# download and unpack latest openresty source
git clone https://github.com/tarantool/nginx_upstream_module.git tarantool_upstream --recursive

# Nobody told me this was necessary :'(
cd tarantool_upstream
make -j `nproc` yajl && make -j `nproc` msgpack || exit
cd ../

./configure --add-module=tarantool_upstream
make
# add some more files, cleanup, etc.
@dedok
Copy link
Contributor

dedok commented Jun 3, 2019

Hi,

thank you for the feedback.

Makefile uses for developing, testing. So if you with to have NGINX with this module installed, then you have to use add-module. But, this module also requires to have installed libyajl-dev and msgpack-dev for installing extra packages you could use yum, dep, etc.

Probably, you have some ideas to make it better, feel free to share it.

Thanks!

@dedok dedok added question Further information is requested need feedback labels Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need feedback question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants