test/smoke/harness: migrate from MailHog to Mailpit #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eliminated `ineffassign` and `staticcheck` tool dependencies - Cleaned up related entries in `Makefile`, `go.mod`, and `go.sum` - Streamlined toolchain and dependencies for efficiency
KatieMSB
previously approved these changes
Oct 7, 2024
KatieMSB
previously approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Overall the tools are very similar, even the integration test needed very minimal changes. That said the integration test now validates that links in the email (like the image) are not broken and will fail if they are. That way this hopefully doesn't happen again (e.g., #1198)
Screenshots:
Describe any introduced user-facing changes:
N/A this is a dev-tool only
Describe any introduced API changes:
N/A this is a dev-tool only