Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plans for supporting react-native? #74

Open
madhums opened this issue Jan 9, 2020 · 2 comments
Open

plans for supporting react-native? #74

madhums opened this issue Jan 9, 2020 · 2 comments

Comments

@madhums
Copy link

madhums commented Jan 9, 2020

Hi, I am trying to use this library within react-native to upload images to Azure blob storage. I ran into the following issues (with some suggestions)

  1. crypto is included but never used. This results in transpiling issues as RN does not support native modules. I think this line should be removed as the crypto module is never used. (usage of a simple linter with pre-commit could solve issues like these in development phase)
  2. util and events are node core module which don't get transpiled and throws errors. Not sure what would be the best way to go about this. One idea would be use ES6 classes which would remove the dependency on util but we would still have a dep on events.

Would love to hear your thoughts about this.

P.S: The official azure sdk also doesn't support React Native yet. Azure/azure-sdk-for-js#5771 I did not come across any existing libraries that support azure storage in RN yet.

@djmitche
Copy link
Contributor

djmitche commented Jan 9, 2020

(1) sounds like it would be a great quick PR.

(2) would be a little trickier, but also doable. I think there's a native-js implementation of event that could be substituted?

@djmitche
Copy link
Contributor

djmitche commented Jan 9, 2020

I don't remember the minimum node version of this library, but I'd be happy to raise that minimum to 10 or even, if necessary, to 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants